Move cgroup v1 to maintenance mode #14538

iholder101 · 2025-04-21T13:43:30Z

What this PR does

The containerized world, including many technologies like Kubernetes, systemd and Kubevirt,
were originally designed to run on cgroup v1.

At this point, cgroup v2 is the default cgroup manager for most distributions and is widely adopted.

Kubernetes had moved cgroup support to maintenance mode in 1.31, and Kubevirt is following this path.

For more info, please look at the Kubernetes blog-post on the subject:
https://kubernetes.io/blog/2024/08/14/kubernetes-1-31-moving-cgroup-v1-support-maintenance-mode/

Quoting from Kubernetes' blog-post:

When cgroup v1 is placed into maintenance mode in Kubernetes, it means that:

Feature Freeze: No new features will be added to cgroup v1 support.
Security Fixes: Critical security fixes will still be provided.
Best-Effort Bug Fixes: Major bugs may be fixed if feasible, but some issues might remain unresolved.

Kubevirt will follow the same principles.

Release note

Move cgroup v1 to maintenance mode

Signed-off-by: Itamar Holder <[email protected]>

sourcery-ai · 2025-04-21T13:43:46Z

Reviewer's Guide by Sourcery

This PR moves cgroup v1 support to maintenance mode in Kubevirt, aligning with the decision made by Kubernetes. This means no new features will be added, security fixes will still be provided, and bug fixes will be handled on a best-effort basis.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added a document explaining the move of cgroup v1 to maintenance mode.	Created a new markdown file detailing the implications of this change for Kubevirt users. Referenced the Kubernetes blog post for additional context.	`docs/cgroup-v1-maintenance-mode.md`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

iholder101 · 2025-04-21T13:43:57Z

/cc @xpivarc

sourcery-ai

Hey @iholder101 - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding a date to the document so readers know when this change was made.

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

sourcery-ai · 2025-04-21T13:44:26Z

docs/cgroup-v1-maintenance-mode.md

+
+Kubernetes had moved cgroup support to maintenance mode in 1.31, and Kubevirt is following this path.
+
+For more info, please look at the Kubernetes blog-post on the subject:


suggestion (typo): Use "blog post" (two words) and "information" instead of "info".

Suggested change

For more info, please look at the Kubernetes blog-post on the subject:

For more information, please look at the Kubernetes blog post on the subject:

0xFelix

From what I can tell

/lgtm

kubevirt-bot · 2025-04-29T10:11:41Z

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

iholder101 · 2025-04-29T11:15:11Z

Any objections / thoughts?
@xpivarc @vladikr @enp0s3

iholder101 · 2025-05-29T12:05:25Z

Any objections / thoughts? @xpivarc @vladikr @enp0s3

ping @xpivarc @vladikr @enp0s3

enp0s3 · 2025-05-29T13:05:57Z

/approve

kubevirt-bot · 2025-05-29T13:06:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enp0s3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-commenter-bot · 2025-05-29T13:06:13Z

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.32-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator

kubevirt-commenter-bot · 2025-05-29T16:56:20Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot · 2025-05-29T20:56:18Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-bot · 2025-05-29T23:56:18Z

/remove-label needs-approver-review

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 21, 2025

kubevirt-bot requested review from 0xFelix and vladikr April 21, 2025 13:43

Move cgroup v1 to maintenance mode

4cf6470

Signed-off-by: Itamar Holder <[email protected]>

kubevirt-bot added the size/S label Apr 21, 2025

iholder101 force-pushed the policy/cgroup-v1-maintenance-mode branch from 7f5780a to 4cf6470 Compare April 21, 2025 13:43

kubevirt-bot requested a review from xpivarc April 21, 2025 13:43

dosubot bot added the kind/deprecation Indicates the PR/issue deprecates a feature that will be removed in a subsequent release. label Apr 21, 2025

sourcery-ai bot reviewed Apr 21, 2025

View reviewed changes

0xFelix reviewed Apr 22, 2025

View reviewed changes

kubevirt-bot assigned 0xFelix Apr 22, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025

kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Apr 29, 2025

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025

kubevirt-bot merged commit 7ecefce into kubevirt:main May 29, 2025
38 checks passed

kubevirt-bot removed the needs-approver-review Indicates that a PR requires a review from an approver. label May 29, 2025

	For more info, please look at the Kubernetes blog-post on the subject:
	For more information, please look at the Kubernetes blog post on the subject:

Move cgroup v1 to maintenance mode #14538

Move cgroup v1 to maintenance mode #14538

Uh oh!

Conversation

iholder101 commented Apr 21, 2025

What this PR does

Release note

Uh oh!

sourcery-ai bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

iholder101 commented Apr 21, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

0xFelix left a comment

Choose a reason for hiding this comment

Uh oh!

kubevirt-bot commented Apr 29, 2025

Uh oh!

iholder101 commented Apr 29, 2025

Uh oh!

iholder101 commented May 29, 2025

Uh oh!

enp0s3 commented May 29, 2025

Uh oh!

kubevirt-bot commented May 29, 2025

Uh oh!

kubevirt-commenter-bot commented May 29, 2025

Uh oh!

kubevirt-commenter-bot commented May 29, 2025

Uh oh!

kubevirt-commenter-bot commented May 29, 2025

Uh oh!

Uh oh!

kubevirt-bot commented May 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sourcery-ai bot commented Apr 21, 2025 •

edited

Loading