Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vamsikrishna-siddu
Copy link
Contributor

@vamsikrishna-siddu vamsikrishna-siddu commented Mar 24, 2025

What this PR does

Before this PR:
The disks-images-provider is pointing to wrong alpine.iso(x86). Because of this one of the virtctl image upload test(test_id:4621) is failing.

After this PR:
The disk-images-provider is now pointed to s390x alpine.iso.

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

     fix: disks-images-provider is pointing to wrong alpine image for s390x.

Signed-off-by: Vamsi Krishna Siddu <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Mar 24, 2025
@dosubot dosubot bot added kind/bug sig/buildsystem Denotes an issue or PR that relates to changes in the build system. labels Mar 24, 2025
Copy link
Contributor

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-kubevirt-generate

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025
@alicefr
Copy link
Member

alicefr commented Mar 25, 2025

/approve
@vamsikrishna-siddu can you please fix the release note?

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicefr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.32-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator

@vamsikrishna-siddu
Copy link
Contributor Author

/approve @vamsikrishna-siddu can you please fix the release note?

sure

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 25, 2025
@vamsikrishna-siddu
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit cb83307 into kubevirt:main Mar 26, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants