-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix the disk-images provider for s390x. #14325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the disk-images provider for s390x. #14325
Conversation
Signed-off-by: Vamsi Krishna Siddu <[email protected]>
akalenyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test pull-kubevirt-generate
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alicefr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Required labels detected, running phase 2 presubmits: |
sure |
|
/retest |
What this PR does
Before this PR:
The disks-images-provider is pointing to wrong alpine.iso(x86). Because of this one of the virtctl image upload test(test_id:4621) is failing.
After this PR:
The disk-images-provider is now pointed to s390x alpine.iso.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note