e2e, netbinding: Don't override binding registration #15552
Conversation
|
Skipping CI for Draft Pull Request. |
d38abcb to
bd17d4d
Compare
|
/test pull-kubevirt-e2e-k8s-1.33-sig-network |
bd17d4d to
92da9af
Compare
|
/cc @frenzyfriday @EdDev |
|
/retest-required |
92da9af to
f93f478
Compare
f93f478 to
8ac4ceb
Compare
|
Fixed lint error. |
8ac4ceb to
fb50967
Compare
fb50967 to
7b57fa0
Compare
dfc27b7 to
464260a
Compare
|
Removed second commit which was meant to improve readability but reviewers disgreed that it did. |
frenzyfriday
left a comment
There was a problem hiding this comment.
/lgtm
But lets wait for Orel's ack
| ) | ||
|
|
||
| func WithNetBindingPlugin(name string, netBindingPlugin v1.InterfaceBindingPlugin) KvChangeOption { | ||
| func WithNetBindingPluginNoOverride(name string, netBindingPlugin v1.InterfaceBindingPlugin) KvChangeOption { |
There was a problem hiding this comment.
ack, kind of makes sense. Maybe we can call it WithNetBindingPluginIfNotPresent or something (but I cannot think of a better name though)
orelmisan
left a comment
There was a problem hiding this comment.
Thank you @nirdothan!
Please consider adding a doc string to clarify the function's behavior.
@frenzyfriday's naming suggestion is also reasonable IMO.
Feel free to unhold.
/approve
/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orelmisan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Required labels detected, running phase 2 presubmits: |
In some testing setups, KubeVirt is configured by external operators e.g [HCO](https://github.com/kubevirt/hyperconverged-cluster-operator). In those setups, this e2e suite should not override preconfigured values, in particular network binding plugins. This change makes this suite respect existing configuration, and only registering network binding plugins, if they are not already registered. Signed-off-by: Nir Dothan <[email protected]>
464260a to
59caf0a
Compare
|
Rebased and implemented comments from @frenzyfriday and @orelmisan in the same push (sorry). |
|
Required labels detected, running phase 2 presubmits: |
|
/unhold |
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
|
/retest-required |
|
@nirdothan: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Some downstream systems pre-regiter the passt network binding plugin. In such cases respect the original registration and do not override it with a localized registration. This is essentially a scaled down backport of kubevirt#15552 for version 1.6 only. Signed-off-by: Nir Dothan <[email protected]>
Some downstream systems pre-regiter the passt network binding plugin. In such cases respect the original registration and do not override it with a localized registration. This is essentially a scaled down backport of kubevirt#15552 for version 1.6 only. Signed-off-by: Nir Dothan <[email protected]>
Some downstream systems pre-register the passt network binding plugin. In such cases respect the original registration and do not override it with a localized registration. This is essentially a scaled down backport of kubevirt#15552 for version 1.6 only. Signed-off-by: Nir Dothan <[email protected]>
What this PR does
In some testing setups, KubeVirt is configured by external operators e.g
HCO.
In those setups, this e2e suite should not override preconfigured
values, in particular network binding plugins.
This change makes this suite respect existing configuration, and it only
registers network binding plugins, if they are not already registered.
The decision to override or not is only based on the name of the
plugin (they do not have a type definition) as it appears in the test,
hence external setups that wish to utilize this functionality,
must align the plugin names that they register with those
that are used by VMs in the test code.
For example: passt binding is called
passtin the test, so do notregister it with the name
passtBinding.Before this PR:
After this PR:
References
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note