Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow L3 network for decentralized migrations #15630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubevirt-bot merged 1 commit into from
Sep 9, 2025
Merged

Allow L3 network for decentralized migrations #15630

kubevirt-bot merged 1 commit into from
Sep 9, 2025

Conversation

@awels
Copy link
Member

@awels awels commented Sep 8, 2025

What this PR does

Remove code that looks up DNS record for the pod ip address. We are really only interested in the pod ip address.

Before this PR:

We would try to look up a DNS record for the IP address and use that. This would cause issues
when we provide the FQDN to the other side since the DNS record doesn't exist there.

After this PR:

Pass the IP address as is instead of looking up the DNS record.

References

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

Allow decentralized live migration on L3 networks

@awels
Allow L3 network for decentralized migrations
b98a101 
Remove code that looks up DNS record for the pod
ip address. We are really only interested in the
pod ip address.

Signed-off-by: Alexander Wels <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S approved-vep Indicates that a PR is tied to an approved VEP and is prioritized. labels Sep 8, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Sep 8, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@awels
Copy link
Member Author

awels commented Sep 9, 2025

/retest

jean-edouard
jean-edouard reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
0xFelix
0xFelix approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@kubevirt-commenter-bot
Copy link

kubevirt-commenter-bot commented Sep 9, 2025

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-k8s-1.31-windows2016
/test pull-kubevirt-e2e-kind-1.33-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.33-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator
/test pull-kubevirt-e2e-k8s-1.32-sig-network
/test pull-kubevirt-e2e-k8s-1.32-sig-storage
/test pull-kubevirt-e2e-k8s-1.32-sig-compute
/test pull-kubevirt-e2e-k8s-1.32-sig-operator

@kubevirt-bot kubevirt-bot merged commit 451c565 into kubevirt:main Sep 9, 2025
41 checks passed
@fossedihelm
Copy link
Contributor

fossedihelm commented Sep 10, 2025

@awels Should we backport this?

@awels
Copy link
Member Author

awels commented Sep 10, 2025

Yes, I think we should. It is pretty small and can allow people to use this with some cloud providers.
/cherry-pick release-1.6

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Sep 10, 2025

@awels: new pull request created: #15648

Details

In response to this:

Yes, I think we should. It is pretty small and can allow people to use this with some cloud providers.
/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Sep 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@xpivarc xpivarc Awaiting requested review from xpivarc

+2 more reviewers

@jean-edouard jean-edouard jean-edouard left review comments

@0xFelix 0xFelix 0xFelix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@0xFelix 0xFelix

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. approved-vep Indicates that a PR is tied to an approved VEP and is prioritized. area/controller dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@awels @kubevirt-bot @kubevirt-commenter-bot @fossedihelm @0xFelix @jean-edouard