Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@akalenyu
Copy link
Contributor

@akalenyu akalenyu commented Sep 9, 2025

What this PR does

we're using the vmim key when
declaring PVC was observed && checking if the expectation was satisfied

but we send out the expectation towards the vmi key,
which is logically wrong.

References

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

BugFix: Windows VM with vTPM that was previously Storage Migrated cannot live migrate

we're using the vmim key when
declaring PVC was observed && checking if the expectation was satisfied

but we send out the expectation towards the vmi key,
which is logically wrong.

Signed-off-by: Alex Kalenyuk <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. area/controller sig/compute size/S labels Sep 9, 2025
I think errcheck would have caught this

Signed-off-by: Alex Kalenyuk <[email protected]>
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@akalenyu
Copy link
Contributor Author

akalenyu commented Sep 9, 2025

/retest

@akalenyu
Copy link
Contributor Author

/cc @jean-edouard
/test pull-kubevirt-e2e-k8s-1.33-sig-compute
(unrelated failure)

Copy link
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 how did I miss that?... Nice catch, thanks!
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@awels
Copy link
Member

awels commented Sep 10, 2025

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-k8s-1.31-windows2016
/test pull-kubevirt-e2e-kind-1.33-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.33-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator
/test pull-kubevirt-e2e-k8s-1.32-sig-network
/test pull-kubevirt-e2e-k8s-1.32-sig-storage
/test pull-kubevirt-e2e-k8s-1.32-sig-compute
/test pull-kubevirt-e2e-k8s-1.32-sig-operator

@kubevirt-bot kubevirt-bot merged commit 7bc1e47 into kubevirt:main Sep 10, 2025
43 checks passed
@akalenyu
Copy link
Contributor Author

/cherrypick release-1.6

@kubevirt-bot
Copy link
Contributor

@akalenyu: new pull request created: #15653

Details

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akalenyu
Copy link
Contributor Author

/cherrypick release-1.5

@kubevirt-bot
Copy link
Contributor

@akalenyu: new pull request created: #15654

Details

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/controller dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/compute size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants