-
Notifications
You must be signed in to change notification settings - Fork 1.6k
backend state migration: use same key in expect/observe #15642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend state migration: use same key in expect/observe #15642
Conversation
we're using the vmim key when declaring PVC was observed && checking if the expectation was satisfied but we send out the expectation towards the vmi key, which is logically wrong. Signed-off-by: Alex Kalenyuk <[email protected]>
I think errcheck would have caught this Signed-off-by: Alex Kalenyuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/retest |
|
/cc @jean-edouard |
jean-edouard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 how did I miss that?... Nice catch, thanks!
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Required labels detected, running phase 2 presubmits: |
|
/cherrypick release-1.6 |
|
@akalenyu: new pull request created: #15653 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-1.5 |
|
@akalenyu: new pull request created: #15654 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does
we're using the vmim key when
declaring PVC was observed && checking if the expectation was satisfied
but we send out the expectation towards the vmi key,
which is logically wrong.
References
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note