[release-1.6] [descheduler] align opt-out annotation name #15384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposal of introducing descheduler.beta.kubernetes.io/evict annotation with Boolean logic to dinamically opt-in/opt-out selected pods as eviction candidates got refused. We got instead an additional alpha annotation named descheduler.alpha.kubernetes.io/prefer-no-eviction that can be used to opt-out selected pods. See: kubernetes-sigs/descheduler#1723 Let's align the code to handle descheduler.alpha.kubernetes.io/prefer-no-eviction instead of descheduler.beta.kubernetes.io/evict. This is just a change in the name of the handled annotation, no actual logic changes. Signed-off-by: Simone Tiraboschi <[email protected]>
ed87515 to
671865b
Compare
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #15365
/assign xpivarc