Bump k8s dependency to 1.19 and add context support #126
Conversation
910d445 to
dc47f22
Compare
|
/hold |
|
/cc @Thor-wl @shinytang6 for extra review due to blocked PR. #123 |
|
@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: Thor-wl, shinytang6. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I think the main purpose of #123 is to avoid the direct dependency to k8s. Then I am wondering if we should upgrade the version to 1.19. Do you want to add context first, then we can eliminate the k8s import packages? |
|
I'm both OK for avoiding the direct depend dependency to k8s first or upgrade to k8s to v1.19 first. You can make a decision @Jeffwan @gaocegege |
@gaocegege I think your concern is reasonable. community is releasing 1.21. It's better to keep < 3 version changes with latest version and we will update to higher version sometime soon. 1.18 brings in context changes, I am ok to bump to 1.18. The major reason I choose 1.19 is because volcano/api now is using 1.19 https://github.com/volcano-sh/apis/blob/cfacea273e7da6b53170cc00ece9b2caf019316f/go.mod#L6-L10 Another possible solution is to ask volcano/api to downgrade to version >=1.16 <=1.17 and we don't need client-go related changes. But we will still need to upgrade dependencies later. |
It's OK for me to provide volcano.sh/apis release-1.17 to match k8s.io v1.17. Look forward to your decision. |
|
|
|
SGTM! I think we will update to a higher version soon. |
@Jeffwan @gaocegege So what's the version shall i provide? |
1. Upgrade k8s dependency to 1.19 2. 1.18 client-go add context and extra options. Adapt to the new changes. 3. Upgrade golang to 1.15 to match golang used in 1.19 Signed-off-by: Jiaxin Shan <[email protected]>
andreyvelich
left a comment
There was a problem hiding this comment.
Thank you for doing this @Jeffwan!
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, Jeffwan, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Use setup.cfg for packaging * Add MANIFEST.in to exclude non-related files from removebg-core, Configure library in pyproject.toml according to PEP-612 * Add requires-python 3.7+ as we introduced dataclasses * Update circleci config to use pip, build and twine instead of setup.py * Adjust manifest * Configure in setup.cfg as requirements do not get installed when specifying in pyproject.toml * Remove PEP-621 pyproject.toml config for now * Update circleci config check and install * Remove wrong progess bar argument * Update packaging to be able to install via pip locally * Update venv path * Set progress bar off * Use FURY_AUTH_TOKEN * Update python requires Co-authored-by: Paul Angerer <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Jiaxin Shan [email protected]