Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rtsp
Copy link
Contributor

@rtsp rtsp commented May 31, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Upgrade ingress-nginx-controller to 1.2.1 https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.2.1

Special notes for your reviewer:
I already compared official chart 4.1.3 vs 4.1.0 using helm template . and confirmed no different except the version annotation and the image tag.

Does this PR introduce a user-facing change?:

[ingress-nginx] upgrade to 1.2.1

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi May 31, 2022 18:01
@floryut floryut added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 1, 2022
@cristicalin
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, rtsp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cristicalin cristicalin added this to the 2.19 milestone Jun 1, 2022
@floryut floryut added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1f65e6d into kubernetes-sigs:master Jun 1, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 1, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants