Fix CI (including disabling features) and update GNU Lightning#108
Merged
Fix CI (including disabling features) and update GNU Lightning#108
Conversation
6caa4d4 to
2958496
Compare
The Homebrew prefix is different on aarch64 from on x86-64.
This should permit building on macOS for aarch64.
2958496 to
71a6232
Compare
59c58ec to
1450dbb
Compare
Calling `$finish(0)` instead of `$finish` keeps the `out` files from containing `$finish called at` lines that cause test failures due to inexact matches against the golden files under `test/compare/vvp/out`.
f75ec53 to
f074a86
Compare
Coverage has bitrotted; it may be restored in a future commit.
7c200ce to
4b87c74
Compare
This was referenced Jan 31, 2026
4b87c74 to
3341eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current PR updates the Lightning version, and collects some other changes that cause CI failures.
CI jobs will fail on macOS because GNU Lightning 2.1.3 does not have
jit_aarch64.h. Lightning 2.2.3 compiles onaarch64macOS, buttsimusing it fails withBus Error, so the JIT is disabled for macOS (see #110).SDL builds fail on Ubuntu due to failing to find webp libraries. This build is disabled for now, to be re-enabled in #109.