chore(*) status poller cleanups #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2020 09:38
Signed-off-by: Nikolay Nikolaev <[email protected]>
Signed-off-by: Nikolay Nikolaev <[email protected]>
jakubdyszkiewicz
approved these changes
Jun 30, 2020
added 3 commits
June 30, 2020 10:39
Signed-off-by: Nikolay Nikolaev <[email protected]>
Signed-off-by: Nikolay Nikolaev <[email protected]>
lobkovilya
reviewed
Jun 30, 2020
| k8sReadOnlyMessage = "On Kubernetes you cannot change the state of Kuma resources with 'kumactl apply' or via the HTTP API." + | ||
| " As a best practice, you should always be using 'kubectl apply' instead." + | ||
| " You can still use 'kumactl' or the HTTP API to make read-only operations. On Universal this limitation does not apply.\n" | ||
| //globalReadOnlyMessage = "On global control plane you can not modify dataplane resources with 'kumactl apply' or via the HTTP API." + |
Contributor
There was a problem hiding this comment.
Is it here intentionally?
Contributor
Author
There was a problem hiding this comment.
yes it is intentional
jakubdyszkiewicz
approved these changes
Jun 30, 2020
| for _, definition := range definitions.All { | ||
| if definition.ResourceFactory().GetType() != mesh.DataplaneType { | ||
| definition.ReadOnly = true | ||
| if cfg.Mode.Mode != mode.Standalone { |
Contributor
There was a problem hiding this comment.
I think this if is not needed if there is a switch below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup the status poller code from the remains of the old HTTP probing mechanism. Also use DialTimeout instead.