Refactor examples to remove use of deprecated winit functions #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ideally, the |
Contributor
Author
I'll look into if I can do it without the window being contained within |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick draft, as I was not sure if you would be picky about the structure in the examples. I've just refactored the existing
Exampleto beExampleInnerwhich is now contained within a newExamplestruct which holds the window/inner. I did this to minimise the amount of changes.I can however go for a different approach and keep the Example struct, but instantiate everything within new() that does not require a Window, and then have a secondary
instantiate(no good name comes to mind right now), that can be called with a window onApplicationHandler::resumed()Will await your thoughts before applying this across all the examples