Update snapcraft.yaml #2
Conversation
|
@kyrofa Looks like you need to approve once as I never PRed to this repo. |
|
Gah, same failure: https://github.com/kyrofa/ignore-me/actions/runs/6277364903/job/17048939042 . Stupid github. I'll need to figure out another way to get the PR number. Thank you @Pilzinsel64, this was helpful. If you can figure out how to use the github API to turn this workflow run into a pull request ID, let me know. I'll investigate as well. |
|
Sure, I will let you know! |
|
@kyrofa something like this, maybe? |
|
Or maybe this via the gh tool: |
|
Yeah we're not using the pull request event, but the workflow_run event, which has different data available. |
|
Ah, I see. |
|
Looks like this is a topic nobody talked about. Maybe I can get little into the API documentation this day. And alrernive would be to rename the snap.snap to snap_prid.snap? This however would still enable thepr owner to push a custom pr Id? |
|
Hm, this sounds definetly like our problem. What do you think @kyrofa? 🤔 But looks like the solution is the same again, upload it as artifact. |
|
The problem is, again, that the PR author has control over which channel
the snap will be pushed to. :sad:
And what about the workaround commented here @kyrofa?
community/community#25220 (comment)
Even though the https://github.com/marketplace/actions/get-workflow-origin
uses a "brute force" approach, it should be OK from a security point of
view, shouldn't it?
El dg., 24 de set. 2023, 11:04, Pilzinsel64 ***@***.***> va
escriure:
… Hm, this sounds definetly better. What do you think @kyrofa
<https://github.com/kyrofa>? 🤔
community/community#25220 (comment)
—
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAY3E6LC5P2SWPC3N26HGB3X37ZSXANCNFSM6AAAAAA5DNOGCI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Haha, I read @Pilzinsel64's link and came to say the same thing as @pachulo. Yes, exactly. That approach sounds promising indeed, I'll give it a shot. Good work, guys! |
|
@Pilzinsel64 okay try rebasing on master. |
|
Oh, you got it? The error now is at least about the snap file being corrupted. |
|
Yeah this is definitely promising, but I'm not sure what's happening now. |
|
Maybe I should edit something else. Give me a sec... |
|
No I found it, re-open. Then I can fix it. You need to rebase on my |
|
Oh, sorry, see #4 |
No description provided.