Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(typescript_indexer): add flag to fail analysis on plugin error #6079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2024
Merged

feat(typescript_indexer): add flag to fail analysis on plugin error #6079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65d37c9
Add option
nbeloglazov Mar 22, 2024
05d4f2d
Merge branch 'master' into mikita/ts-error-on-failure
nbeloglazov Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kythe/typescript/indexer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2755,6 +2755,9 @@ export function index(compilationUnit: CompilationUnit, options: IndexingOptions
try {
plugin.index(indexingContext);
} catch (err) {
if (indexingContext.options.failAnalysisOnPluginError) {
throw err;
}
console.error(`Plugin ${plugin.name} errored:`, err);
}
}
Expand Down
13 changes: 6 additions & 7 deletions kythe/typescript/plugin_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,17 @@ export interface IndexingOptions {
*/
readFile?: (path: string) => Buffer;

/**
* When enabled emits 0-0 spans at the beginning of each file that represent
* current module. By default 0-1 spans are emitted. Also this flag changes it
* to emit `defines/implicit` edges instead of `defines/binding`.
*/
emitZeroWidthSpansForModuleNodes?: boolean;

/**
* When enabled, ref/call source anchors span identifiers instead of full
* call expressions when possible.
*/
emitRefCallOverIdentifier?: boolean;

/**
* When enabled any error thrown from any plugin gets propagated to the caller.
* Currently errors from plugins are logged without interrupting analysis.
*/
failAnalysisOnPluginError?: boolean;
}


Expand Down