Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix type mismatch error in MatrixMarket #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fix type mismatch error in MatrixMarket #81

merged 2 commits into from
Dec 22, 2023

Conversation

@dkkim1005
Copy link
Member

@dkkim1005 dkkim1005 commented Dec 21, 2023 •
edited
Loading

Type mismatch error in MatrixMarket class is fixed, reported at the issue#80. All test cases(test code: tests/data/test_mm.py) passed, and CF methods(ALS, pLSI, EALS) that employ a MatrixMarket instance also worked properly.

$ nosetests ./data/test_mm.py -v

test0_get_default_option (data.test_mm.TestMatrixMarket) ... ok
test1_is_valid_option (data.test_mm.TestMatrixMarket) ... ok
test2_create (data.test_mm.TestMatrixMarket) ... [INFO    ] 2023-12-21 21:53:33 [mm.py:247] Create the database from matrix market file.
[DEBUG   ] 2023-12-21 21:53:33 [mm.py:252] Building meta part...
^M[PROGRESS] 0.00% 0.0/0.0secs 0.00it/s^M[PROGRESS] 100.00% 0.0/0.0secs 834.22it/s
[INFO    ] 2023-12-21 21:53:33 [mm.py:260] Creating working data...
^M[PROGRESS] 0.00% 0.0/0.0secs 0.00it/s^M[PROGRESS] 100.00% 0.0/0.0secs 190,949.48it/s
[DEBUG   ] 2023-12-21 21:53:33 [mm.py:264] Working data is created on /tmp/tmp32f8ummv
[INFO    ] 2023-12-21 21:53:33 [mm.py:265] Building data part...
[INFO    ] 2023-12-21 21:53:33 [base.py:417] Building compressed triplets for rowwise...
[INFO    ] 2023-12-21 21:53:33 [base.py:418] Preprocessing...
[INFO    ] 2023-12-21 21:53:33 [base.py:421] In-memory Compressing ...
[INFO    ] 2023-12-21 21:53:33 [base.py:301] Load triplet files. Total job files: 73
[INFO    ] 2023-12-21 21:53:33 [base.py:451] Finished
[INFO    ] 2023-12-21 21:53:33 [base.py:417] Building compressed triplets for colwise...
[INFO    ] 2023-12-21 21:53:33 [base.py:418] Preprocessing...
[INFO    ] 2023-12-21 21:53:33 [base.py:421] In-memory Compressing ...
[INFO    ] 2023-12-21 21:53:34 [base.py:301] Load triplet files. Total job files: 73
[INFO    ] 2023-12-21 21:53:34 [base.py:451] Finished
[INFO    ] 2023-12-21 21:53:34 [mm.py:279] DB built on ./mm.h5py
ok

...... (skip logs)

test3_list (data.test_mm.TestMatrixMarketReader) ... [DEBUG   ] 2023-12-21 21:53:36 [mm.py:70] creating temporary matrix-market data from numpy-kind array
ok

----------------------------------------------------------------------
Ran 10 tests in 3.271s

OK

@ita9naiwa ita9naiwa merged commit 6a8312f into kakao:dev Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ita9naiwa ita9naiwa ita9naiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkkim1005 @ita9naiwa