Add XmlMultipleChoicePromptTemplate and ExtractDiscreteAnswerFromXml
#922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFeucht
reviewed
Oct 21, 2025
| IMPORTANT: Respond with a valid JSON object where the "{{ answer_key }}" key | ||
| contains your answer, and "{{ reason_key }}" should contain a brief | ||
| explanation for why the provided answer was chosen. | ||
| IMPORTANT: Respond with a valid JSON object where the "{{ answer_key }}" key contains your answer. |
There was a problem hiding this comment.
Suggested change
| IMPORTANT: Respond with a valid JSON object where the "{{ answer_key }}" key contains your answer. | |
| IMPORTANT: Respond with a valid JSON object with a single "{{ answer_key }}" key that contains your answer. |
There was a problem hiding this comment.
In the raw template it says
IMPORTANT: You must provide your reasoning first, then end your response with only your final answer
- I suggest we either explicitly mention here to reason first as well, or we leave it out in both cases. I'd be in favor of keeping it everywhere if CoT is enabled and use the phrasing here if not.
So with enable_cot:
IMPORTANT: You must provide your reasoning first, then end your response with a valid JSON object with a single "{{ answer_key }}" key that contains your answer.
Without:
IMPORTANT: Respond with a valid JSON object with a single "{{ answer_key }}" key that contains your answer.
There was a problem hiding this comment.
Or we keep the phrasing "reasoning" in general, since this can also apply to non-CoT responses. What do you think? Also related to the comment below
Comment on lines
43
to
+46
| Example JSON Answer: | ||
| Your explanation for why you chose this answer can go here... | ||
| {{ '{' }} | ||
| "{{ answer_key }}": "{{ example_answer }}", | ||
| "{{ reason_key }}": "{{ example_reason }}" | ||
| "{{ answer_key }}": "{{ example_answer }}" |
There was a problem hiding this comment.
Suggestion:
Example Answer:
Your reasoning for why you chose this answer can go here...
{{ '{' }}
"{{ answer_key }}": "{{ example_answer }}"
{{ '}' }}
| {{ context }} | ||
| {% endif %} | ||
| IMPORTANT: Provide your final answer within <{{ answer_key }}></{{ answer_key }}> tags. |
There was a problem hiding this comment.
Same as above, let's align the instruction across templates
| {{ answer_options }} | ||
| Example Answer: | ||
| Your explanation for why you chose this answer can go here... <{{ answer_key }}>{{ example_answer }}</{{ answer_key }}> |
There was a problem hiding this comment.
And same here with the phrasing of "reasoning"
| self.answer_key = answer_key | ||
|
|
||
| @override | ||
| def render( |
There was a problem hiding this comment.
Seems like this and the JSON template render func are the same, perhaps we can unify that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #921
ExtractDiscreteAnswerFromStructuredOutputabstract base class which is implemented by both the JSON & XML extractors.JsonMultipleChoicePromptTemplateremoving thereasonkey from the requested JSON format and allowing the models to provide their reasoning outside the structured JSON answer template.Example
results in this prompt: