Venus 22.7.0 plat 25584#13684
Conversation
|
@github-copilot suggest |
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to preserve the original creation timestamp when cloning annotation cue points. When an annotation is cloned, the system now stores the original cue point's creation time in a new field to maintain historical tracking.
Key Changes
- Added
originalCuePointCreateAtfield to store the source cue point's creation timestamp during cloning operations - Implemented getter/setter methods in the Annotation model for the new field
- Updated the clone action to populate this field, either from an already-cloned annotation or from the original creation time
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/cue_points/annotation/services/AnnotationService.php | Implements logic in cloneAction to retrieve and set the original creation timestamp |
| plugins/cue_points/annotation/lib/model/Annotation.php | Adds constant, getter, and setter methods for storing the original creation timestamp in custom data |
| plugins/cue_points/annotation/lib/api/KalturaAnnotation.php | Exposes the new originalCuePointCreateAt field in the API response |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $dbAnnotation->setParentId($parentId); | ||
| } | ||
|
|
||
| //save the original annotation cue point createAt time on field originalCuePointCreateAt |
There was a problem hiding this comment.
Extra space between 'save' and 'the'. Should be a single space.
| //save the original annotation cue point createAt time on field originalCuePointCreateAt | |
| //save the original annotation cue point createAt time on field originalCuePointCreateAt |
|
|
||
| /** | ||
| * In case of cloned annotation it will hold source cuepoint createdAt. | ||
| * @var time |
There was a problem hiding this comment.
The @var type should be int instead of time. The value is stored as a Unix timestamp (integer), as evidenced by the use of $dt->getTimestamp() in the service layer.
| * @var time | |
| * @var int |
Co-authored-by: Copilot <[email protected]>
|
@github-copilot suggest |
Pull Request Checklist
Please complete the following before submitting:
General notes -
New Kaltura Types
New Kaltura Services / Actions
Questions
What is the purpose of this PR?
Does this change affect production code or infrastructure?
If yes, what is the rollback plan?