fix: add orderby descending id if orderby is not set in request SUP-5…#13709
Merged
noahsol30 merged 2 commits intoVenus-22.9.0from Dec 9, 2025
Merged
fix: add orderby descending id if orderby is not set in request SUP-5…#13709noahsol30 merged 2 commits intoVenus-22.9.0from
noahsol30 merged 2 commits intoVenus-22.9.0from
Conversation
|
@github-copilot suggest |
|
|
||
| if ($filter->orderBy === null) | ||
| { | ||
| $filter->orderBy = KalturaAdminUserOrderBy::ID_DESC; |
Collaborator
There was a problem hiding this comment.
You cant use api type KalturaA.... in core code, plus KalturaAdminUserOrderBy. is not related here
|
@github-copilot suggest |
MosheMaorKaltura
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…0269
Pull Request Checklist
Please complete the following before submitting:
General notes -
New Kaltura Types
New Kaltura Services / Actions
Questions
What is the purpose of this PR?
Does this change affect production code or infrastructure?
If yes, what is the rollback plan?