first draft implementation of a simpler Kanela agent #1385
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For years I have been annoyed by having our custom ByteBuddy build in Kanela, especially because the actual changes are minimal but required every time we want to bump the ByteBuddy version, which usually happens when we want to support new Java versions. Somehow Kanela was always a black box to me, a box that @dpsoft maintained for long time but lately he doesn't have time to maintain anymore, so I decided to that its time to take ownership of Kanela and try to solve these inconveniences once and for all.
I created a new project and tried my best to copy and distill down to the features and code that we actually use in Kamon. In the process I also:
As implementation details, if you look at the work @hughsimpson did at https://github.com/kamon-io/kanela/pull/160/files#diff-453ff6f7f27a9f4c86c4e8bac64f766ee1a93cdc3c7c7c43b69dcc17433e1a80 in an attempt to automate creating that patched ByteBuddy jar, there are a few changes:
kanela-dependenciesproject takes care of having the right dependencies in place and shading them in the same way that the ByteBuddy build would havedefaultandinterfacefrom the list of reserved keywords. The Akka/Pekko/http4s instrumentations use the wordinterfaceas argument names and that makes ByteBuddy unhappy. I didn't get to test this yet, but I'm hoping that we will be able to workaround it without a custom build. I'd rather do a nasty reflection hack to modify that set that having a separate build just for that.Things that need to be done:
kanela-dependenciescan make IntelliJ unhappy (it works fine from metals, though)