Add kamon-opensearch #1324
Merged
Add kamon-opensearch #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hughsimpson , Could you please review this? |
2dad5e8 to
c53fad3
Compare
|
This seems reasonable to me. Will try to get a passing CI build before merging (curse these flaky tests...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is no support for instrumenting OpenSearch 1.x client even though the clients are vastly similar. I have duplicated the instrumentation for ElasticSearch and made the appropriate changes to support the OpenSearch client.
The changes can be summarized as below,
All test cases are green.