You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was in the middle of doing a Rails project and overriding the default template. I did some ERB linting and the suite told me the following message:
erb interpolation with '<%= (...).html_safe %>' in this context is never safe
In file: app/views/kaminari/_first_page.html.erb:10
My original expectation for this request was to be sanitized, but it isn't. I ended up by fixing the view code to use the sanitize(...) method to prevent potential XSS attacks. It allows the method to properly read the characters in a sanitized context.
I was not sure if it makes sense to sanitize translations, as they are not user inputs. It may actually break the HTML, as they are supposed not to be sanitized. Rather than calling sanitize everywhere, is there any way we could introduce _html-suffixed translations, as documented here? This could be a breaking change though.
I was not sure if it makes sense to sanitize translations, as they are not user inputs. It may actually break the HTML, as they are supposed not to be sanitized. Rather than calling sanitize everywhere, is there any way we could introduce _html-suffixed translations, as documented here? This could be a breaking change though.
@yuki24 I think that is also doable and will make changes accordingly to that.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was in the middle of doing a Rails project and overriding the default template. I did some ERB linting and the suite told me the following message:
My original expectation for this request was to be sanitized, but it isn't. I ended up by fixing the view code to use the
sanitize(...)method to prevent potential XSS attacks. It allows the method to properly read the characters in a sanitized context.Let me know if you have any questions for me.