Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon a corner case where Kaminari explodes with a
divided by 0error and wanted to offer a fix. The usage is a little contrived / self inflicted, but kaminari should probably be more resilient to user silliness.Repro:
the issue arises because in
.per, this library useslimit_valueto recalculate the new offset value. but iflimit_valueis 0, it explodes. It's unclear what the offset should be set to (since we don't store page number, only offset), but resetting to 0 seemed sane.Open to a bugfix?