specify required ruby version#847
Merged
amatsuda merged 1 commit intokaminari:masterfrom Jan 11, 2017
Merged
Conversation
Member
|
@timoschilling Well, I think you made a good point, but since we've already released 1.0.0 that doesn't include this directive, I'm afraid adding this to the next release won't actually help the 1.9 users to find the one that works for them. I'm wondering if we'd better have this in the gemspec still... |
Contributor
Author
|
Yes it don't solve any Problem, but it will help in some cases, for example a Gem which uses kaminari can say |
7a45cc1 to
a921b95
Compare
Member
|
All right, I'll merge this. TBH I'm still not 100% sure how would this help the ActiveAdmin's case, but it shouldn't be a bad thing to have in our gemspec anyway. |
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kaminari 1.0 works only with Ruby >2, this helps Bundler to find Kaminari versions for Ruby 1.9