Coerce num param to int and assign to @_padding#840
Merged
yuki24 merged 1 commit intokaminari:masterfrom Dec 14, 2016
pcriv:master
Merged
Coerce num param to int and assign to @_padding#840yuki24 merged 1 commit intokaminari:masterfrom pcriv:master
yuki24 merged 1 commit intokaminari:masterfrom
pcriv:master
Conversation
Member
|
Could you add a test case? |
Contributor
Author
|
Sure! |
Contributor
Author
|
@yuki24 test added |
Member
|
It looks great! Could you also squash the commit into the previous one? |
Contributor
Author
|
Will do! |
This avoids code failing when calling "Model.padding(params[:padding] || 0)" since params[:padding] is a string.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids code failing when calling
Model.padding(params[:padding] || 0)sinceparams[:padding]is a string.