Add edit note button to reader view #1917
Draft
+113
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MohamedBassem 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Deploying karakeep-landing with
|
| Latest commit: |
543a33b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e240a658.karakeep-landing.pages.dev |
| Branch Preview URL: | https://copilot-add-edit-button-for.karakeep-landing.pages.dev |
Deploying karakeep-docs with
|
| Latest commit: |
0861774
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9881f3c0.karakeep-docs.pages.dev |
| Branch Preview URL: | https://copilot-add-edit-button-for.karakeep-docs.pages.dev |
Co-authored-by: MohamedBassem <[email protected]>
Copilot
AI
changed the title
[WIP] Add button to edit notes
Add edit note button to reader view
Sep 8, 2025
Copilot finished work on behalf of
MohamedBassem
September 8, 2025 19:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an "Edit Note" button to the reader view header, allowing users to edit bookmark notes directly without having to navigate back to the list view and use the three-dots menu.
Problem
Previously, users viewing a bookmark in the reader view had no way to edit the associated note. The only way to edit notes was to:
This was cumbersome and disrupted the reading flow.
Solution
Added an "Edit Note" button (pencil icon) to the reader view header, positioned between the Print and Settings buttons. When clicked, it opens a modal dialog where users can edit the bookmark's note directly.
Changes Made
NoteEditModal.tsx: A new modal component that provides a clean interface for editing notes with Save/Cancel functionalityBenefits
The implementation reuses existing components and hooks, ensuring consistency with the rest of the application while providing the requested functionality.
Fixes #1913.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.comnode /home/REDACTED/work/karakeep/karakeep/node_modules/.bin/next build --experimental-build-mode compile(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.