Upgrade depedencies (tantivy, sled), clean up Cargo.toml #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
As an aside, I would recommend a full |
Owner
|
@lberezy Thanks, this looks great! Thanks for pointing out the issue with generating IDs. I haven't been following the development of sled (or tantivy) that closely recently, but it looks like this is now fixed by allowing I think I'd cargo fmtted everything, but I will be sure to check in my |
Owner
|
@lberezy Oh, nevermind, I see you fixed it so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the versions of
tantivyandsledto their latest respective versions, addressing the issue where the current state of the crate is unable to build. This also removes the need to patch thesledcrate as those changes have been upstreamed.I've also upgrade and moved the
tempfiledependency to a dev-dependency as it's only used in an example.There were a few minor breaking changes to both
tantivyandsled. I'm not 100% familiar with these crates so I have only done work to get the example to build and run, so not sure about any subtle bugs I may have introduced. My main concern is with how IDs are now generated from aTransactionalTree, required to not hang inside of a transaction context.