Support font synthesis; remove deps harfbuzz-rs & fontdue; update deps #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The harfbuzz_rs crate appears unmaintained and is redundant with rustybuzz.
Fontdue does not support font variations and is redundant.
|
Behold faux-bold effects over a cursive font (Z003): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font synthesis is now propagated and applied to
ab_glyphandrustybuzzfont faces (Swash requires this be applied downstream when rastering glyphs). Caveat: font metrics available throughScaledFaceRefare not adjusted; results when using font variations withoutrustybuzzmay not account for adjusted glyph size properly while cursor position, highlights and decorations may not be perfect. So far my testing hasn't found any big issues however.https://github.com/harfbuzz/harfbuzz_rs is removed as a dependency since it appears to be unmaintained and is redundant with
rustybuzz. https://github.com/mooman219/fontdue is removed as a dependency since it doesn't appear to support font synthesis and is redundant withab_glyphandswash.The
kas-textversion is bumped to v0.8.0 since there are breaking changes, though release is not planned just yet. README tweaks.