Increase code-coverage to 90% #48

jjuliano · 2025-06-07T13:01:33Z

In this release, the goal it towards a high coverage score for higher robustness and producibility.

…s for cmd, data, docker, logging, template, texteditor, version, and workflow packages

…implementations, modify item handling, update ktx constants, improve resource testing, enhance utils functionality, and update workflow implementation

cursor

Bug: Race Condition in Schema Version Retrieval

Replacing sync.Once with sync.Map in SchemaVersion() introduces a race condition. When UseLatest is true, concurrent calls to SchemaVersion() can cause multiple goroutines to simultaneously fetch the schema version via utils.GitHubReleaseFetcher(). This leads to redundant API calls, as the sync.Map caching mechanism does not guarantee single-execution initialization like sync.Once did.

pkg/schema/schema.go#L20-L42

kdeps/pkg/schema/schema.go

Lines 20 to 42 in 1078d22

    
           // SchemaVersion(ctx) fetches and returns the schema version based on the cmd.Latest flag. 
        
           func SchemaVersion(ctx context.Context) string { 
        
           	if UseLatest { // Reference the global Latest flag from cmd package 
        
           		// Try to get from cache first 
        
           		if cached, ok := versionCache.Load("version"); ok { 
        
           			return cached.(string) 
        
           		} 
        
           		// If not in cache, fetch it 
        
           		version, err := utils.GitHubReleaseFetcher(ctx, "kdeps/schema", "") 
        
           		if err != nil { 
        
           			fmt.Fprintf(os.Stderr, "Error: Unable to fetch the latest schema version for 'kdeps/schema': %v\n", err) 
        
           			exitFunc(1) 
        
           		} 
        
           		// Store in cache 
        
           		versionCache.Store("version", version) 
        
           		return version 
        
           	} 
        
           	// Use the specified version if not using the latest 
        
           	return specifiedVersion 
        
           }

Fix in Cursor

Bug: Function Pointer Called Without Nil Check

The dr.LoadResourceFn function pointer is called without a nil check. If uninitialized, this will cause a runtime panic, which is inconsistent with other function pointers introduced in this change that include nil checks and fallbacks.

pkg/resolver/resource_http.go#L93-L94

kdeps/pkg/resolver/resource_http.go

Lines 93 to 94 in 1078d22


	res, err := dr.LoadResourceFn(dr.Context, pklPath, HTTPResource)

pkg/resolver/resources.go#L100-L101

kdeps/pkg/resolver/resources.go

Lines 100 to 101 in 1078d22

    
           // Load the resource file 
        
           res, err := dr.LoadResourceFn(dr.Context, file, Resource)

Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

…bal timeout overrides; bump coverage

jjuliano added 29 commits June 6, 2025 21:54

test: add comprehensive test coverage across packages - Add test file…

0b49cd9

…s for cmd, data, docker, logging, template, texteditor, version, and workflow packages

refactor: update core packages and dependencies - Update cmd package …

cd7b324

…implementations, modify item handling, update ktx constants, improve resource testing, enhance utils functionality, and update workflow implementation

add passing tests for template

bb65e7f

refactor: update core packages and dependencies - Update cmd package …

515bf04

…implementations, modify item handling, update ktx constants, improve resource testing, enhance utils functionality, and update workflow implementation

add coverage badge

5ad4b80

added gh badges

fa03f41

add version on kdeps and list scaffold resources

12243b8

specify the gist_id for the ci badgge

7067b12

change coverage file output to test.out

8e83b1c

add fail-fast mode to debug failing tests in GHA

8592a21

fix failing tests

03dea11

fix GHA failing tests

12ce5c0

fix GHA failing tests

f5db757

mv templates to project rootdir

75bed8c

added cmd cli tests

8243121

fix schema tests

d65686a

fix gha step for generating test.out coverage report

e550d74

Update README.md - FIx badges

f55761c

increase test coverage further

3bf686f

fix message expectations for InterpreterNotFound tool test

612ba53

fix message expectations for invalid script file tool test

f450d76

improve test coverage

25915b3

added extra tests

dbbc9e3

Update README.md - updated badges

4e191fb

increase resolver coverage to 40%

6f3b7a7

increase resolver coverage to 50%

7825b78

add DI tests

a336f80

delegate all exec tasks to a central kdeps executor

9fb02c2

bump overall coverage to 65%

b273fd7

This comment was marked as outdated.

Sign in to view

bump coverage

d1f5e97

This comment was marked as outdated.

Sign in to view

bump coverage

1078d22

cursor bot reviewed Jun 13, 2025

View reviewed changes

jjuliano added 23 commits June 13, 2025 17:15

removed test monkey-patching

18cfaac

consolidate constants to pkg/messages; improve json renderer; add glo…

90ac304

…bal timeout overrides; bump coverage

added more tests; pass -short on ci tests

a35e250

bump coverage to 68%

b86f355

fix gha build

f51b423

bump coverage and fix gha test run

ba85adf

try fix gha build

a106a61

fix test.out output for badge tool ingestion

03055c9

enable verbose mode on gha builds for fixing cover tool ingestion

9d69f5b

bump coverage tests

d001c77

set cover threshold to 70%; bump to 68.7%

5fdd44f

Removed stupid padding test. Add more tests

3cce4e9

boost coverage to 69.4%

c3a2b89

add more coverage tests at 69.7%

0d76231

bump to 69.8%

2cb2062

bump coverage

c9452ee

bump coverage to 69.9%

86da090

add more test coverage

54c586c

bump coverage to 70%

a307805

merge tests to single test files

6790d9c

merge tests to single test files

6f996b3

bump coverage to 70%

d2365b8

temporarily strict the linter

7c99cf3

jjuliano merged commit 0f4a344 into main Jun 18, 2025
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Increase code-coverage to 90% #48

Increase code-coverage to 90% #48

Uh oh!

jjuliano commented Jun 7, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// SchemaVersion(ctx) fetches and returns the schema version based on the cmd.Latest flag.
	func SchemaVersion(ctx context.Context) string {
	if UseLatest { // Reference the global Latest flag from cmd package
	// Try to get from cache first
	if cached, ok := versionCache.Load("version"); ok {
	return cached.(string)
	}

	// If not in cache, fetch it
	version, err := utils.GitHubReleaseFetcher(ctx, "kdeps/schema", "")
	if err != nil {
	fmt.Fprintf(os.Stderr, "Error: Unable to fetch the latest schema version for 'kdeps/schema': %v\n", err)
	exitFunc(1)
	}

	// Store in cache
	versionCache.Store("version", version)
	return version
	}

	// Use the specified version if not using the latest
	return specifiedVersion
	}

	// Load the resource file
	res, err := dr.LoadResourceFn(dr.Context, file, Resource)

Increase code-coverage to 90% #48

Increase code-coverage to 90% #48

Uh oh!

Conversation

jjuliano commented Jun 7, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Race Condition in Schema Version Retrieval

Bug: Function Pointer Called Without Nil Check

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants