tests: add more coverage for keywords #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
approved these changes
Sep 21, 2021
Member
zkat
left a comment
There was a problem hiding this comment.
oh snap. Nice catch. Please be sure to file individual issues for those parsers. this should be fixed for sure.
This was referenced Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
I noticed that bare identifiers with a prefix that matches a keyword seem to confuse both the JS and Rust implementations into failing to parse. I don't think that's the desired behavior, so I added the following test cases that would be failing for those implementations.
Happy to change the tests around if folks have opinions or remove/merge some if you think any are redundant.
For example, the following two lines each fail:
But these pass: