Minor updates to Winnie #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `wdb.circumstellar_model_rescale()` to rescale model inside of class to simplify `obj_fn` code.
Minimize calls to `run_rdi` in objective function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be useful to put the
model_rescale_factor()function into utils.py and compile some fo the scaling code into acircumstellar_model_rescale()method to theSpaceRDIclass. Updates Tutorial 2 to simply some of the function definitions. Thecircumstellar_model_rescale()function is also handy for on-the-fly rescaling of the model..Also fixed a bug on
reduc_labelbug for forward modeling display.And using
image_manip.crop_imageinstead ofnp.padin one specific instance to handle both cases of padding and cropping.