Exposed GlobalIdx on Get/Set instructions #58
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the GlobalIdx property for Global Get/Set instructions in order to make them accessible for WASM file parsing. Key changes include:
- Changing the private GlobalIdx field to a public property in InstGlobalGet.
- Applying the same change in InstGlobalSet.
- Removing excess whitespace at the file's end.
| public InstGlobalGet() : base(ByteCode.GlobalGet, +1) { } | ||
|
|
||
| private GlobalIdx Index; | ||
| public GlobalIdx Index { get; private set; } |
There was a problem hiding this comment.
[nitpick] Consider adding XML documentation for the public Index property in InstGlobalGet to clarify its purpose and usage.
| public InstGlobalSet() : base(ByteCode.GlobalSet, -1) { } | ||
|
|
||
| private GlobalIdx Index; | ||
| public GlobalIdx Index { get; private set; } |
There was a problem hiding this comment.
[nitpick] Consider adding XML documentation for the public Index property in InstGlobalSet to ensure consistency and clarity in its usage.
|
Instruction immediates should not be directly accessible. Changing these to a property will drastically impact execution performance. If you just need the value for inspecting the wasm bytecode, adding a getter to access the private field is a better option. |
|
Thanks for the feedback. I'll open another PR with a GetIndex() function instead. |
I'm using WACS to parse WASM files and read the instructions. The Global Get/Set instructions aren't very useful without these exposed!