Adding weight initialization options #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kengz
approved these changes
Nov 3, 2018
Owner
kengz
left a comment
There was a problem hiding this comment.
beautiful, this brings proper weight init functionality to the lab!
will merge to staging first, then:
- some minor stylefix (name
fxntofnper conventions in the lab) - apply the new init_layers function to all networks
kengz
added a commit
that referenced
this pull request
Nov 3, 2018
* Adding weight initialization options (#223) * Adding vizdoom functionality (hat tip @joelouismarino) * Typos * Typo/bug * Adding weight initialization options in Net specification * Code cleanup * extend init_fxn to other mlp * extend recurrent layer init fxn comment * extend init_fxn doc in convnet * rename fxn to fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature / Fix
torch.nn.initinitialization function for their network in the net section ofspecfiles.