Publish operator image to Quay #10719
Conversation
|
Tested on my private Dockerhub account (tag 6.7.8): |
| - name: Cache Maven packages | ||
| id: cache | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: | | ||
| ~/.m2/repository | ||
| key: cache-1-${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} | ||
| restore-keys: cache-1-${{ runner.os }}-m2 | ||
|
|
||
| - name: Build locally Keycloak artifacts to avoid depending on Maven | ||
| run: | | ||
| mvn clean install -DskipTests -DskipExamples -DskipTestsuite |
There was a problem hiding this comment.
IIRC, we actually wanted to depend on Maven central so we could build just the operator module in this workflow. Or not? @stianst
There was a problem hiding this comment.
From experience, the sync with Maven Central can take several hours (even 1 day or so), relying on the local cache prevents to be affected from those delays.
I warmly suggest we use the local cache, but if you understand the downsides and still prefer to rely on upstream published jars I'm ready to adapt this PR.
There was a problem hiding this comment.
I don't have a strong opinion about this. Let's wait @stianst.
There was a problem hiding this comment.
Would prefer to just pull the actually released artefacts rather than building here. We could pull those directly from https://s01.oss.sonatype.org/ instead of Maven Central as they will be available there straight away.
Since this is just a temporary solution until we move to the new release process I'm okay with this for now. However, building the whole of Keycloak just because you need keycloak-common is quite pointless.
If you build the Operator with:
mvn -P operator -pl operator -am clean package
That should take care of building the Operator and the dependencies it needs.
There was a problem hiding this comment.
Updated the command to:
mvn -P operator -pl operator -am clean install -DskipTestsit's indeed much faster! Thanks for the suggestion!
c10066d to
aec1a4b
Compare
Resolves #10436