Authorization services refactoring#10728
Merged
hmlnarik merged 10 commits intokeycloak:mainfrom Mar 22, 2022
Merged
Conversation
For entities outside of Authz we use RealmModel as first parameter for each method, to be consistent with this we move ResourceServer to the first place for each method in authz
pedroigor
approved these changes
Mar 22, 2022
vramik
approved these changes
Mar 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains refactoring of Authz services interfaces.
The main changes:
ResourceServerorResource) as the first parameter of each method (similarly as Realm for other entities)String resourceServerIdtoResourceServer resourceServer)I tried to split the changes into more commits, but it may happen there are some conflicts between commits, for example, commit 1 may contain some changes removed by commit 3 and so on. Sorry for that.
Also, the first commit fe5417a contains changes that should be probably part of #10509. I used the changes for that issue as a base for the refactoring and then we realized it would be better to do the refactoring separately, however, removing that commit means a significant amount of time spent on resolving conflicts as changes done in that commit are in the same lines as other refactoring changes. So I decided to leave the changes in the interfaces/services/model in this PR and remove changes in Map storage. This means the code distinguishes between
Client.idandResourceServer.id, but it is always the same.@vramik I will send this as a draft PR because I am not sure this is complete, if you find something is missing please let me know and I will add it.