Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enhance Map authz entities with REALM_ID (ResourceServer with CLIENT_… #10889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hmlnarik merged 1 commit into from
May 3, 2022
Merged

Enhance Map authz entities with REALM_ID (ResourceServer with CLIENT_… #10889

hmlnarik merged 1 commit into from
May 3, 2022

Conversation

@vramik
Copy link
Contributor

@vramik vramik commented Mar 23, 2022

…ID) searchable field

Closes #10883

@vramik vramik requested a review from hmlnarik March 23, 2022 11:19
@vramik vramik requested a review from mhajas March 23, 2022 11:19
@vramik vramik mentioned this pull request Mar 25, 2022
Closed
@vramik vramik force-pushed the 10883-authz-realmid branch from 52d1994 to cf53a5b Compare March 25, 2022 11:24
@vramik
Copy link
Contributor Author

vramik commented Mar 28, 2022

#10965

@mhajas mhajas mentioned this pull request Apr 1, 2022
Closed
@vramik vramik force-pushed the 10883-authz-realmid branch 2 times, most recently from 59f14df to 860d747 Compare April 7, 2022 14:18
@vramik vramik force-pushed the 10883-authz-realmid branch 3 times, most recently from a49e984 to 3552cca Compare April 28, 2022 09:35
@vramik vramik marked this pull request as ready for review April 28, 2022 10:46
mhajas
mhajas reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vramik! I added two comments

@vramik vramik force-pushed the 10883-authz-realmid branch from 3552cca to 55d023c Compare May 2, 2022 12:44
@vramik vramik requested a review from mhajas May 2, 2022 12:45
mhajas
mhajas approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vramik

hmlnarik
hmlnarik previously approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@hmlnarik hmlnarik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per @mhajas' approval

mhajas
mhajas suggested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just looking at the model test results and it seems the failures are relevant, could you have a look @vramik

@vramik vramik force-pushed the 10883-authz-realmid branch from 55d023c to ec19cde Compare May 3, 2022 08:46
mhajas
mhajas approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. That was my fault

@vramik vramik requested a review from hmlnarik May 3, 2022 10:18
@vramik
Copy link
Contributor Author

vramik commented May 3, 2022

@mhajas np at all! Thank you.

hmlnarik
hmlnarik approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@hmlnarik hmlnarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving

@hmlnarik hmlnarik merged commit 0d83b51 into keycloak:main May 3, 2022
@vramik vramik deleted the 10883-authz-realmid branch May 5, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hmlnarik hmlnarik hmlnarik approved these changes

@mhajas mhajas mhajas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vramik vramik

@hmlnarik hmlnarik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance Map authz entities with REALM_ID (ResourceServer with CLIENT_ID) searchable field

3 participants

@vramik @hmlnarik @mhajas