Fix slow deletion on deleteClientSessionsByRealm and deleteClientSessionsByUser when using mysql and mariadb by converting sub-query to join
#12611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essionsByUser` when using mysql and mariadb by converting sub-query to join
vramik
approved these changes
Oct 25, 2022
Contributor
|
LGTM |
Contributor
|
Do we know this will not make the other databases slower? Maybe there was a reason why it was a subquery? |
Contributor
By default the query remains the same: https://github.com/keycloak/keycloak/pull/12611/files#diff-14cc500714de7a7b3d908dbdaf9ddcb7abcf77686777b9daa0a290c6c78579d3R12 ... it's replaced only for mysql and mariadb |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
From this issue #12523 background.
I found that the PR #8415 fixes the slow query on
deleteExpiredClientSessions.Features
This PR fixes another 2 slow queries on
deleteClientSessionsByRealmanddeleteClientSessionsByUserwhen using mysql and mariadb by converting sub-query to join.I test in my local and the SQL runs normally.