-
Notifications
You must be signed in to change notification settings - Fork 7.9k
scope parameter in refresh flow #12043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Moreover, UserInfo must be restricted based on Access Token scopes. For example access token produced by refresh flow with scope parameter. |
2075110 to
42804c5
Compare
|
I have rebase it to main. I would like to mention that based on documentation only access token scopes are filtering based on scope parameter. Refresh token scope - if must be returned - are not changed. Could you review the PR in order Keycloak to be compliant with OAuth refresh token flow? |
mposolda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgeorgilakis Sorry for late response. Thanks for this PR! Added few minor comments inline.
Could you please also rebase this PR on top of latest main? This should also trigger the GH actions build.
services/src/main/java/org/keycloak/protocol/oidc/TokenManager.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oidc/endpoints/UserInfoEndpoint.java
Outdated
Show resolved
Hide resolved
...ation-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oauth/OfflineTokenTest.java
Outdated
Show resolved
Hide resolved
I will make corrections and rebase. I will only do it next week due to conference participation. |
3fddf19 to
45405a4
Compare
mposolda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgeorgilakis Thanks, much better now. I've added 2 minor comments regarding tests. One is follow-up of your previous change. Second is something I overlooked before...
There is also DCO check failing in your PR. This is new check added recently to Keycloak due CNCF requirements about adding signatures to the commits. See https://github.com/keycloak/keycloak/blob/main/CONTRIBUTING.md#developers-certificate-of-origin . Is it possible to squash commits in this PR and make sure that your signature is added?
...ation-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oauth/OfflineTokenTest.java
Outdated
Show resolved
Hide resolved
...ation-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oauth/RefreshTokenTest.java
Outdated
Show resolved
Hide resolved
Of course, I will do it before merging. Could you see my last changes and comments before proccessing to this? |
mposolda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgeorgilakis Thanks! I see your update in RefreshTokenTest.
So it looks that remaining points are to update OfflineTokenTest and fix DCO and this PR is good to go IMO.
...ation-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oauth/OfflineTokenTest.java
Outdated
Show resolved
Hide resolved
...ation-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oauth/OfflineTokenTest.java
Outdated
Show resolved
Hide resolved
|
@cgeorgilakis Thanks for your latest changes. It seems that if you squash the commits and add the signature to fix |
Closes keycloak#12009 Signed-off-by: cgeorgilakis-grnet <[email protected]>
182d141 to
87c9549
Compare
Done. |
mposolda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgeorgilakis Thanks! I hope to merge once tests are ok
Closes #12009