Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bs-matil
Copy link
Contributor

@bs-matil bs-matil commented Aug 1, 2022

One way to fix #13469

The documentation PR is keycloak/keycloak-documentation#1658

@bs-matil bs-matil changed the title suppress confirmation screen for logout in oidc suppress confirmation screen for logout in oidc with new flag Aug 1, 2022
@mposolda mposolda self-assigned this Aug 8, 2022
@mposolda mposolda added missing/tests area/oidc Indicates an issue on OIDC area and removed missing/tests labels Aug 8, 2022
@mposolda
Copy link
Contributor

mposolda commented Aug 8, 2022

@bs-matil Thanks for this change. +1 for this approach.

Is it possible to also send PR to the keycloak/keycloak-documentation repository and introduce file "Migrating to 19.0.2" and add some note about this new switch? The previous switch was already documented https://www.keycloak.org/docs/latest/upgrading/#openid-connect-logout

@bs-matil
Copy link
Contributor Author

bs-matil commented Aug 8, 2022

@mposolda I filed the PR for the docs keycloak/keycloak-documentation#1652

NOTE: The corresponding documentation PR is keycloak/keycloak-documentation#1658

mposolda
mposolda previously approved these changes Aug 10, 2022
@mposolda
Copy link
Contributor

@bs-matil I would like to merge this, but unfortunately there are some conflicts. Could you please rebase to latest Keycloak main and update this PR with the rebased version?

@sschu sschu force-pushed the disable-logout-confirmation-with-new-flag branch from 308c3a2 to cc102da Compare August 10, 2022 13:59
mposolda
mposolda previously approved these changes Aug 10, 2022
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sschu Thanks for the update!

I am approving. I hope to merge once the tests are ok

@sschu sschu force-pushed the disable-logout-confirmation-with-new-flag branch from cc102da to 738139c Compare August 10, 2022 14:14
@mposolda mposolda merged commit fa383bf into keycloak:main Aug 10, 2022
bs-matil added a commit to bosch-io/keycloak that referenced this pull request Aug 11, 2022
mposolda pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/oidc Indicates an issue on OIDC area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make compatibility mode for oidc logout endpoint fully compatible to previous keyloak versions

2 participants