Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added KERBEROS feature. Disable it when running tests on FIPS #16478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 1 commit into from
Jan 25, 2023
Merged

Added KERBEROS feature. Disable it when running tests on FIPS #16478

mposolda merged 1 commit into from
Jan 25, 2023

Conversation

@mposolda
Copy link
Contributor

@mposolda mposolda commented Jan 16, 2023

closes #14966

@mposolda mposolda self-assigned this Jan 16, 2023
@mposolda mposolda force-pushed the 14966-fips-kerberos-2 branch from 5042776 to 88ec0f4 Compare January 16, 2023 13:51
@mposolda mposolda mentioned this pull request Mar 15, 2023
Closed
@mposolda mposolda force-pushed the 14966-fips-kerberos-2 branch from 88ec0f4 to 1553728 Compare January 24, 2023 07:44
@ghost ghost added the flaky-test label Jan 24, 2023
ghost
ghost reviewed Jan 24, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Jan 24, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNode

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (TIMED_WAITING): locked on java.util.concurrent.FutureTask@77fc5ab7 waiting for 96147 ms blocked for 0 ms
	at [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
	at [email protected]/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:234)
	at [email protected]/java.util.concurrent.FutureTask.awaitDone(FutureTask.java:444)
...

Report flaky test

@mposolda mposolda mentioned this pull request Jan 24, 2023
Open
@mposolda mposolda force-pushed the 14966-fips-kerberos-2 branch 2 times, most recently from d804c7e to 85d9b19 Compare January 25, 2023 11:03
@ghost
Copy link

ghost commented Jan 25, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.DeviceActivityTest#signOutTest

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Expected WelcomeScreen but was Keycloak Account Management (https://localhost:8543/auth/realms/test/account/)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

ghost
ghost reviewed Jan 25, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@mposolda mposolda force-pushed the 14966-fips-kerberos-2 branch from 85d9b19 to 3f275ce Compare January 25, 2023 12:43
ghost
ghost reviewed Jan 25, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Jan 25, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#resourcesTest

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Element should be visible expected:<true> but was:<false>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.keycloak.testsuite.util.UIAssert.assertElementVisible(UIAssert.java:47)
...

Report flaky test

@mposolda mposolda requested a review from pedroigor January 25, 2023 17:29
@mposolda mposolda merged commit a804400 into keycloak:main Jan 25, 2023
@mposolda
Copy link
Contributor Author

mposolda commented Jan 25, 2023

@pedroigor Thanks!

This was referenced Jan 27, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FIPS: Failures related to Kerberos/SPNEGO (introduce "KERBEROS" feature)

2 participants

@mposolda @pedroigor