Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade Infinispan to 14.0.13.Final#21565

Merged
mhajas merged 1 commit intokeycloak:mainfrom
ahus1:is-21564-upgrade-infinispan
Jul 20, 2023
Merged

Upgrade Infinispan to 14.0.13.Final#21565
mhajas merged 1 commit intokeycloak:mainfrom
ahus1:is-21564-upgrade-infinispan

Conversation

@ahus1
Copy link
Member

@ahus1 ahus1 commented Jul 10, 2023

Closes #21564

@ahus1 ahus1 self-assigned this Jul 10, 2023
@ahus1
Copy link
Member Author

ahus1 commented Jul 10, 2023

Waiting for Infinispan 14.0.12 Docker image to become available as this is needed for the tests: https://quay.io/repository/infinispan/server?tab=tags&tag=latest

@ahus1 ahus1 force-pushed the is-21564-upgrade-infinispan branch from 5cedd3e to ae9b2f6 Compare July 11, 2023 10:07
@pruivo
Copy link
Member

pruivo commented Jul 11, 2023

@ahus1 My suggestion would be to use infinispan-bom. Example: pruivo@c495233

@ahus1
Copy link
Member Author

ahus1 commented Jul 11, 2023

@pruivo - yes, using the BOM would be a good thing. Still I don't know what else breaks/changes around that. When moving to the BOM, I'd also see some versions set in the "quarkus/runtime/pom.xml" and it would require more thought to clean that up IMHO.

Let's keep the fingers crossed that a small change is possible for this upgrade.

The most confusing thing is that it was putting the right dependencies in the Quarkus distribution of Keycloak, but used the wrong library in some module's JUnit tests. Definitely something to clean up in a follow-up PR.

@ahus1
Copy link
Member Author

ahus1 commented Jul 11, 2023

Model tests

mvn -B test -Dtest=RoleModelTest -Phot-rod

fail with

RoleModelTest.testCompositeRolesPaginationQueries » HotRodClient org.hibernate.search.util.common.SearchException: Exception while searching locally
java.util.concurrent.ExecutionException: org.hibernate.search.util.common.SearchException: HSEARCH000587: Unable to provide the exact total hit count: only a lower-bound approximation is available. This is generally the result of setting query options such as a timeout or the total hit count threshold. Either unset these options, or retrieve the lower-bound hit count approximation through '.total().hitCountLowerBound()'.
org.hibernate.search.util.common.SearchException: HSEARCH000587: Unable to provide the exact total hit count: only a lower-bound approximation is available. This is generally the result of setting query options such as a timeout or the total hit count threshold. Either unset these options, or retrieve the lower-bound hit count approximation through '.total().hitCountLowerBound()'.

due to https://issues.redhat.com/browse/ISPN-15036.

I'm considering this issue now blocked until another Infinispan micro release. Needing some help from @mhajas / @martin-kanis, possibly @pruivo / @ryanemerson to apply a possible workaround if we decide we don't want to wait.

@ahus1
Copy link
Member Author

ahus1 commented Jul 20, 2023

Waiting for files to appear on Maven central

@vmuzikar
Copy link
Contributor

@pruivo - yes, using the BOM would be a good thing. Still I don't know what else breaks/changes around that. When moving to the BOM, I'd also see some versions set in the "quarkus/runtime/pom.xml" and it would require more thought to clean that up IMHO.

Let's keep the fingers crossed that a small change is possible for this upgrade.

The most confusing thing is that it was putting the right dependencies in the Quarkus distribution of Keycloak, but used the wrong library in some module's JUnit tests. Definitely something to clean up in a follow-up PR.

This is actually related to our recent discussion in #21363.

I can imagine there might be some conflicts between deps coming from Quarkus BOM and deps coming from ISPN BOM. Question also is productization. I still do think that ultimately we should align with Quarkus to avoid conflicts but I understand we need to adopt ISPN releases faster.

vmuzikar
vmuzikar previously approved these changes Jul 20, 2023
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM from cloud native perspective.

Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahus1, the PR looks good, I added one comment to the main pom file.

@ahus1 ahus1 force-pushed the is-21564-upgrade-infinispan branch from c7ea25b to 2a47d7d Compare July 20, 2023 15:00
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @ahus1

@mhajas mhajas enabled auto-merge (squash) July 20, 2023 15:02
@mhajas mhajas merged commit 7c9593f into keycloak:main Jul 20, 2023
@ahus1 ahus1 deleted the is-21564-upgrade-infinispan branch September 21, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Infinispan 14.0.13.Final

4 participants