Scope parameter in Oauth 2.0 token exchange#21638
Merged
pedroigor merged 1 commit intokeycloak:mainfrom Dec 18, 2023
Merged
Conversation
pedroigor
reviewed
Dec 6, 2023
services/src/main/java/org/keycloak/protocol/oidc/DefaultTokenExchangeProvider.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oidc/DefaultTokenExchangeProvider.java
Outdated
Show resolved
Hide resolved
183b32f to
8d62917
Compare
0c1b615 to
fa87bcf
Compare
pedroigor
reviewed
Dec 7, 2023
Contributor
pedroigor
left a comment
There was a problem hiding this comment.
@cgeorgilakis Can you please sign the commit by setting -s when creating it?
Otherwise, only a single comment but not a blocker. LGTM.
Closes keycloak#21578 Signed-off-by: cgeorgilakis-grnet <[email protected]>
fa87bcf to
53fad51
Compare
Contributor
Author
I have done it. |
pedroigor
approved these changes
Dec 18, 2023
Contributor
|
@cgeorgilakis Thanks. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21578