Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check RDN attribute for DN membership #21774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 1 commit into from
Jul 21, 2023
Merged

Check RDN attribute for DN membership #21774

ahus1 merged 1 commit into from
Jul 21, 2023

Conversation

@rmartinc
Copy link
Contributor

@rmartinc rmartinc commented Jul 18, 2023

Closes #20718

The PR just returns the groups members whose DN starts with the specified attribute name (for example, CN for for groups or UID for users). This allows to differentiate entries that are groups or users. Note that they can even be the same (for example in AD, both users and groups usually use CN as the RDN attribute). Checking the code this is already being done although later on (for example when getting the user name here or here or getting the group name here). So no real change in behavior.

Tests modified to add a non-existent member that uses a different RDN attribute.

@rmartinc rmartinc requested review from a team as code owners July 18, 2023 09:19
@rmartinc rmartinc requested a review from a team July 18, 2023 09:19
@rmartinc rmartinc requested a review from a team as a code owner July 18, 2023 09:19
@ghost ghost mentioned this pull request Jul 18, 2023
Closed
@ghost
Copy link

ghost commented Jul 18, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientIdleTimeoutSmallerThanSessionNoRefresh

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected null, but was:<org.keycloak.models.sessions.infinispan.AuthenticatedClientSessionAdapter@74ea278f>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotNull(Assert.java:756)
	at org.junit.Assert.assertNull(Assert.java:738)
	at org.junit.Assert.assertNull(Assert.java:748)
...

Report flaky test

org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientIdleTimeoutSmallerThanSessionNoRefresh

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected null, but was:<org.keycloak.models.sessions.infinispan.AuthenticatedClientSessionAdapter@6e35babf>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotNull(Assert.java:756)
	at org.junit.Assert.assertNull(Assert.java:738)
	at org.junit.Assert.assertNull(Assert.java:748)
...

Report flaky test

ghost
ghost reviewed Jul 18, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@vramik vramik self-requested a review July 20, 2023 11:43
vramik
vramik approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@vramik vramik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rmartinc for the PR! LGTM.

ahus1
ahus1 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @vramik's review

@ahus1 ahus1 merged commit 7336ff0 into keycloak:main Jul 21, 2023
@ahus1
Copy link
Contributor

ahus1 commented Jul 21, 2023

@rmartinc - thank you for this fix. IMHO it would be worth back-porting this to KC22 so we'd have fewer known issues in that release.

@rmartinc rmartinc mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+2 more reviewers

@vramik vramik vramik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NullPointerException in GroupTreeResolver with LDAP

3 participants

@rmartinc @ahus1 @vramik