Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Increase timeout for legacy tests #21811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stianst merged 1 commit into from
Jul 19, 2023
Merged

Increase timeout for legacy tests #21811

stianst merged 1 commit into from
Jul 19, 2023

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Jul 19, 2023

Closes #21810

@stianst stianst requested a review from a team as a code owner July 19, 2023 12:42
@stianst stianst enabled auto-merge (squash) July 19, 2023 12:42
@stianst stianst merged commit 54f8c8d into keycloak:main Jul 19, 2023
@ghost ghost added the flaky-test label Jul 19, 2023
This was referenced Jul 19, 2023
Closed
Closed
Closed
ghost
ghost reviewed Jul 19, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Jul 19, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.ResetPasswordTest#resetPasswordWithSpnegoEnabled

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected LoginPage but was  (https://localhost:8543/auth/realms/test/login-actions/authenticate?session_code=ev4-mGud_sdG0Tn4ulZ5YN5F843lSSihBm0ST8zh2sQ&execution=4599cffa-5bee-4ae8-9d85-b3eec9143490&client_id=test-app&tab_id=iMjkXoYM7GY)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:236)
...

Report flaky test

stianst added a commit to stianst/keycloak that referenced this pull request Jul 24, 2023
@stianst
Increase timeout for legacy tests (keycloak#21811)
515920c 
Closes keycloak#21810
ahus1 pushed a commit that referenced this pull request Jul 24, 2023
@stianst @ahus1
Increase timeout for legacy tests (#21811)
e90047f 
Closes #21810
This was referenced Sep 4, 2023
Closed
Closed
Closed
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
@stianst stianst deleted the increase-legacy-timeout branch July 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increase timeout-minutes for legacy store

2 participants

@stianst @ahus1