-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove scheduled from individual workflows #21847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
previously approved these changes
Jul 20, 2023
jonkoops
previously approved these changes
Jul 20, 2023
jonkoops
approved these changes
Jul 20, 2023
Passing run #8166 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
This was referenced Jul 20, 2023
ahus1
approved these changes
Jul 21, 2023
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this change. One thing to note: Once you start workflow with "gh", AFAIK you'll no longer receive email when they fail.
stianst
added a commit
to stianst/keycloak
that referenced
this pull request
Sep 4, 2023
stianst
added a commit
that referenced
this pull request
Sep 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger all nightly workflows through a single schedule workflow. This has a few benefits compared to what we are doing now:
At the same time it's changing the nightly CI to run a single time instead of multiple times. The testsuite in general is stable enough now that we don't need to run multiple times, and we also now have the ability to see if the workflows fail/retried for PRs.