Downgrade Jansi library to prevent kcadm exception on Windows#21926
Downgrade Jansi library to prevent kcadm exception on Windows#21926vmuzikar merged 1 commit intokeycloak:mainfrom
Conversation
There was a problem hiding this comment.
@Pepo48 Thanks for the fix!
I'm not sure if downgrading is the long-term solution for us. The missing WindowsAnsiOutputStream is not considered a bug from Jansi side and migrating to WindowsAnsiPrintStream is probably not something we can easily do. Sticking to old version doesn't seem like an option even from the potential CVEs perspective. Maybe we could use some alternative solution for now?
Closes keycloak#21851 Signed-off-by: Peter Zaoral <[email protected]>
Discussed offline. Since this is not a downgrade per se, but rather a revert to the state before introducing the Quarkus Platform BOM, we can live with it for now. In the future we plan to get rid of the |
mabartos
left a comment
There was a problem hiding this comment.
Unfortunately, I wasn't able to reproduce the issue with the latest upstream main, but as it's pretty difficult to reproduce it and the others have encountered the problem, the issue is valid for sure.
I tried this approach on the Win machine, and everything seems to be working as expected. I executed the command multiple times, made some experiments, and I've never faced the exception.
|
no worries @mabartos, I couldn't reproduce it on an OpenStack VM as well - #21851 (comment). I've got "luck" only with my personal W11 machine. Thanks for the review anyway! |
ahus1
left a comment
There was a problem hiding this comment.
Better late than never: I tested 22.0.1 and reproduced the problem on a Windows machine, and also reproduced that this PR fixes it. Thanks!
Thanks for the review, @ahus1 🙂 |
Closes #21851
The Quarkus Platform BOM that we introduced in #21426 contains
jansiversion 2.4.0.WindowsAnsiOutputStreamisn't though present in the later versions of the library.org.jboss.aeshseems to use the olderWindowsAnsiOutputStream, which is replaced byWindowsAnsiPrintStreamin the more recent versions. Therefore, the easiest way to overcome the exception is to override back to the compatible version 1.18.