Merged
Conversation
stianst
reviewed
Jul 25, 2023
Contributor
stianst
left a comment
There was a problem hiding this comment.
LGTM
I'm running the DeployedScriptAuthenticatorTest 30 times on Windows here to check if it works now:
https://github.com/stianst/keycloak/actions/runs/5654860411
1 flaky tests on run #8228 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication test > should add a condition |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
stianst
approved these changes
Jul 25, 2023
Contributor
stianst
left a comment
There was a problem hiding this comment.
30 runs passed here https://github.com/stianst/keycloak/actions/runs/5654860411
mposolda
added a commit
to mposolda/keycloak
that referenced
this pull request
Jul 26, 2023
Closes keycloak#21778 keycloak#21779 keycloak#21780 (cherry picked from commit bb8ba1a)
This was referenced Sep 4, 2023
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21778 #21779 #21780
There are 2 problems with the script tests.
When the Quarkus server is restarted on Windows, it is a chance that some H2 DB transactions, which were commited shortly before the restart, are lost. So for instance when some test (like
DeployedScriptAuthenticatorTest, but can be any other test) importstestrealm, and then restarts server, it is a chance that after restart, thetestrealm is not available. Something about this is described in the H2 documentation http://repository.transtep.com/repository/thirdparty/H2/1.0.63/docs/html/advanced.html#durability_problems . I've added delay 2 seconds on windows before restart the server, which should ensure all the commited transactions should be synced to the diskAll the script tests are doing deploy/undeploy of script archives after every method, which makes them very uneffective and bad for performance as each deploy/undeploy causes server restart. I've changed this to deploy/undeploy once per class (before class and after class).