Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix conditional checking for PR testing #21947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stianst merged 2 commits into from
Jul 25, 2023
Merged

Fix conditional checking for PR testing #21947

stianst merged 2 commits into from
Jul 25, 2023
+35 −25

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Jul 25, 2023 •
edited
Loading

Can be tested locally with:

.github/actions/conditional/conditional.sh keycloak/keycloak refs/pull/21947/merge

Replace 21947 with a different PR number to see results for different PRs.

@stianst stianst requested a review from a team as a code owner July 25, 2023 10:14
@stianst stianst force-pushed the fix-conditional-checking branch from c7c6cce to 9468ab2 Compare July 25, 2023 10:15
@stianst stianst linked an issue Jul 25, 2023 that may be closed by this pull request
Conditional jobs match if there are changes in main #21946
Closed
@stianst stianst force-pushed the fix-conditional-checking branch from 9468ab2 to 4c503a4 Compare July 25, 2023 10:36
@stianst stianst marked this pull request as draft July 25, 2023 10:39
@stianst stianst force-pushed the fix-conditional-checking branch 2 times, most recently from 8d77d27 to 2d5842f Compare July 25, 2023 11:50
@stianst stianst force-pushed the fix-conditional-checking branch from 2d5842f to 18e81d3 Compare July 25, 2023 11:57
@stianst stianst marked this pull request as ready for review July 25, 2023 12:02
@cypress
Copy link

cypress bot commented Jul 25, 2023

Passing run #8231 ↗︎

0 527 48 0 Flakiness 0

Details:

Merge 18e81d3 into 23f3a1a...
Project: Keycloak Admin UI Commit: bda164258c ℹ️
Status: Passed Duration: 16:56 💡
Started: Jul 25, 2023 12:07 PM Ended: Jul 25, 2023 12:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

jonkoops
jonkoops previously approved these changes Jul 25, 2023
View reviewed changes
@stianst stianst merged commit 8848dfe into keycloak:main Jul 25, 2023
@ghost ghost added the flaky-test label Jul 25, 2023
ghost
ghost reviewed Jul 25, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Jul 25, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#testScriptAuthenticatorNotAvailable

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldWorkWithScriptAuthenticator

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: expected:<201> but was:<404>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldFailWithScriptAuthenticator

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: expected:<201> but was:<404>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

@ghost ghost mentioned this pull request Jul 25, 2023
Closed
ghost
ghost reviewed Jul 25, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Jul 25, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginDifferentUserAfterDisabledUserThrownOut

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError: Expected LoginPage but was Keycloak Account Management (https://localhost:8543/auth/realms/test/account/#/)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:236)
...

Report flaky test

stianst added a commit to stianst/keycloak that referenced this pull request Sep 4, 2023
@stianst @jonkoops
Fix conditional checking for PR testing (keycloak#21947)
1520049 
* Fix conditional checking for PR testing

Closes keycloak#21946

* Update .github/actions/conditional/action.yml

Co-authored-by: Jon Koops <[email protected]>

---------

Co-authored-by: Jon Koops <[email protected]>
stianst added a commit that referenced this pull request Sep 4, 2023
@stianst @jonkoops
Fix conditional checking for PR testing (#21947)
cb04845 
* Fix conditional checking for PR testing

Closes #21946

* Update .github/actions/conditional/action.yml

Co-authored-by: Jon Koops <[email protected]>

---------

Co-authored-by: Jon Koops <[email protected]>
This was referenced Sep 6, 2023
Closed
Closed
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
@stianst stianst deleted the fix-conditional-checking branch July 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jonkoops jonkoops jonkoops left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conditional jobs match if there are changes in main

2 participants

@stianst @jonkoops