Profile activation for WF app server doesn't properly work for Windows#21948
Merged
hmlnarik merged 1 commit intokeycloak:mainfrom Jul 27, 2023
Merged
Profile activation for WF app server doesn't properly work for Windows#21948hmlnarik merged 1 commit intokeycloak:mainfrom
hmlnarik merged 1 commit intokeycloak:mainfrom
Conversation
Contributor
Author
|
Build pipeline executed: https://keycloak-jenkins.com/view/Keycloak/job/keycloak-build-pipeline/223/ |
Contributor
Author
|
The GHA failures are not related to this PR. |
Contributor
Author
Contributor
Author
|
Failures in both pipelines are not related to these changes. Everything's working as expected. Even for the adapter testing of other JBoss-based app servers, only the particular app server is built. @miquelsi Could you please review this PR? Thanks! Adapter pipeline: https://keycloak-jenkins.com/view/Keycloak/job/universal-test-pipeline-adapters/1767/ |
miquelsi
approved these changes
Jul 27, 2023
hmlnarik
approved these changes
Jul 27, 2023
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #21284
Related-to: #21716
For Unix-like systems, the WildFly app server is built by default as the profile
app-server-wildflyis activated by default. However, for Windows systems, the other profile(windows-properties-cli) is activated, and based on the Maven profile activation principles[1], profiles activated by theactiveByDefaultproperty are disabled.It means the WildFly app server is not implicitly built on Windows systems.
For Windows, we can specify another profile for building the module and avoid the logic behind the
activeByDefault.However, for our pipeline, when some other app server is used, the Wildfly would always be built as well (for Windows). We can prevent it by providing a property(
skipAppServerWildfly) for disabling the profile for Windows. On a local Windows machine, even when the other app server is specified, the WF is built, but I don't see a big problem around that, as the approach with the WildFly app server as the default one, is only temporary.Keycloak pipeline MR: https://keycloak-gitlab.com/keycloak/keycloak-pipeline/-/merge_requests/276
[1] https://maven.apache.org/guides/introduction/introduction-to-profiles.html#implicit_profile_activation
@miquelsi Could you please check it?
cc: @ahus1 @Pepo48