Thanks to visit codestin.com
Credit goes to github.com

Skip to content

21360 updated bouncycastle to jdk15to18 1.75#21369

Closed
sschu wants to merge 1 commit intokeycloak:mainfrom
bosch-io:21368_update_bouncycastle_to_jdk15to18_1.75
Closed

21360 updated bouncycastle to jdk15to18 1.75#21369
sschu wants to merge 1 commit intokeycloak:mainfrom
bosch-io:21368_update_bouncycastle_to_jdk15to18_1.75

Conversation

@sschu
Copy link
Contributor

@sschu sschu commented Jun 30, 2023 •
edited
Loading

Implements #21360 (potentially/partly)

I am not sure anymore if this is the way to go or somehow align with Quarkus as mentioned in #21360.

@sschu sschu requested review from a team as code owners June 30, 2023 15:10
@sschu sschu requested a review from a team June 30, 2023 15:10
@sschu sschu added this to the 22.0.0 milestone Jun 30, 2023
@sschu sschu changed the title 21368 updated bouncycastle to jdk15to18 1.75 21360 updated bouncycastle to jdk15to18 1.75 Jun 30, 2023
@ahus1
Copy link
Member

ahus1 commented Jul 6, 2023

Not sure if this is related: There is an effort to move to the Quarkus BOM #21426

@vmuzikar
Copy link
Contributor

vmuzikar commented Jul 6, 2023

@ahus1 #21360 is a follow-up from #21426.

We should probably align bouncycastle versions with the Quarkus BOM. WDYT @pedroigor @mposolda?

@pedroigor
Copy link
Contributor

pedroigor commented Jul 6, 2023

Sorry, I thought I have commented about this somewhere ...

I think we should just use *-jdk18on because we don't need to support JVMs earlier than 1.8. And we are using JDK17 which supports multi-release JARs.

@vmuzikar Looking at Quarkus, it seems we can align the artifacts/versions.

@sschu
Copy link
Contributor Author

sschu commented Jul 7, 2023

@pedroigor Fine for me. I will go ahead and close this one. Please note that @stianst wanted to have the bouncy castle update in KC22. Will the quarkus BOM alignment be done for KC22?

@sschu sschu closed this Jul 7, 2023
@pedroigor
Copy link
Contributor

pedroigor commented Jul 7, 2023

I think so, looks like @vmuzikar is looking at this.

@vmuzikar vmuzikar mentioned this pull request Jul 10, 2023
Merged
@vmuzikar
Copy link
Contributor

vmuzikar commented Jul 10, 2023 •
edited
Loading

PR for alignment with Quarkus BOM #21543. We'd like to have this in for 22.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

team/cloud-native

Projects

None yet

Milestone

22.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sschu @ahus1 @vmuzikar @pedroigor