Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle GitHub logout properly#22463

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
tondrusk:KC-22461
Aug 28, 2023
Merged

Handle GitHub logout properly#22463
ahus1 merged 1 commit intokeycloak:mainfrom
tondrusk:KC-22461

Conversation

@tondrusk
Copy link
Contributor

@tondrusk tondrusk commented Aug 15, 2023 •
edited
Loading

This solution ensures that the logout process is on the correct URL while trying to click on the "Sign out" button.

Additionaly, the GitHub test cases lacked the profile info update method so this PR incorporates it to both test cases.

@tondrusk
Handle GitHub logout properly
f4e6b84 
Add profile info update to GitHub login test cases

Signed-off-by: Tomas Ondrusko <[email protected]>
@ghost ghost added the flaky-test label Aug 24, 2023
@ghost ghost mentioned this pull request Aug 24, 2023
Closed
ghost
ghost reviewed Aug 24, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Aug 24, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterWithUserProfileTest#testEmailAsOptional

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor552.invoke(Unknown Source)
...

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor552.invoke(Unknown Source)
...

Report flaky test

org.keycloak.testsuite.forms.RecoveryAuthnCodesAuthenticatorTest#test03AuthenticateRecoveryAuthnCodes

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az408-563', ip: '10.1.0.185', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.0-1041-azure', java.version: '17.0.8'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

This was referenced Aug 24, 2023
Closed
Closed
Closed
Closed
@tondrusk tondrusk requested a review from wojnarfilip August 25, 2023 09:35
@tondrusk tondrusk marked this pull request as ready for review August 25, 2023 09:37
@tondrusk tondrusk requested review from a team as code owners August 25, 2023 09:37
@tondrusk tondrusk requested a review from a team August 25, 2023 09:37
@tondrusk tondrusk requested a review from a team as a code owner August 25, 2023 09:37
@tondrusk
Copy link
Contributor Author

tondrusk commented Aug 25, 2023 •
edited
Loading

Related Jenkins run: https://master-jenkins.redhat.com/view/RH-SSO/job/universal-test-pipeline-server/2937/testReport/org.keycloak.testsuite.broker/SocialLoginTest/

wojnarfilip
wojnarfilip approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@wojnarfilip wojnarfilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job Tomáš !

ahus1
ahus1 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @wojnarfilip's review

@ahus1 ahus1 merged commit e70ffd0 into keycloak:main Aug 28, 2023
@tondrusk tondrusk mentioned this pull request Sep 1, 2023
Closed
@tondrusk tondrusk deleted the KC-22461 branch October 4, 2023 12:34
tondrusk added a commit to tondrusk/keycloak that referenced this pull request Nov 21, 2023
@tondrusk
Handle GitHub logout properly (keycloak#22463)
ebb35d4 
Add profile info update to GitHub login test cases

Closes keycloak#22461

Signed-off-by: Tomas Ondrusko <[email protected]>
(cherry picked from commit e70ffd0)
ahus1 pushed a commit that referenced this pull request Nov 27, 2023
@tondrusk @ahus1
Handle GitHub logout properly (#22463)
83cfb74 
Add profile info update to GitHub login test cases

Closes #22461

Signed-off-by: Tomas Ondrusko <[email protected]>
(cherry picked from commit e70ffd0)
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+2 more reviewers

@wojnarfilip wojnarfilip wojnarfilip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect logout from GitHub

3 participants

@tondrusk @ahus1 @wojnarfilip