Fix cache option defaults in help #22708
Conversation
There was a problem hiding this comment.
A bit lengthy and strange to add the extra Note at the end.
I'd suggest something along the lines of:
By default in production mode, a 'ispn' cache is used to create a cluster between multiple server nodes. By default in development mode, a local cache disables clustering and is intended for development and testing purposes.
Looking at the docs:
It's says ispn is the default, but not sure how we can easily change that since there's two different defaults, maybe we just live with it as is for now
There was a problem hiding this comment.
Changed per your suggestion.
It's says
ispnis the default, but not sure how we can easily change that since there's two different defaults, maybe we just live with it as is for now
Yeah, doesn't seem simple enough to do. We could probably do it as a follow-up as it concerns more than just cache option.
ghost
left a comment
There was a problem hiding this comment.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.ui.account2.LinkedAccountsTest#linkAccountTestKeycloak CI - Account Console IT (firefox) |
caf6489 to
9a431ae
Compare
Closes keycloak#22707 Co-authored-by: Stian Thorgersen <[email protected]>
9a431ae to
eb0ef15
Compare
Closes keycloak#22707 Co-authored-by: Stian Thorgersen <[email protected]> (cherry picked from commit 1811c39)
Closes #22707 Co-authored-by: Stian Thorgersen <[email protected]> (cherry picked from commit 1811c39)
We could change the description based on the profile used but this approach would be problematic with the generated docs. So kept it simple for now and added just a text note there.
Closes #22707